Skip to content

Conversation

@asbjornu
Copy link

This pull doesn't really add any new functionality, it just makes it easier to use ReSharper with the solution.

@dnewcome
Copy link
Owner

dnewcome commented Jul 1, 2011

This pull can't be merged automatically so I need to go through and merge this manually.

I think some things like the references I already fixed. The 0.2 version of IronJS should only have a single dll file (IronJS.dll) to reference. IronJS.Runtime.dll didn't ship with the 0.2 binary releases. I'm not sure if this has been re-added in later versions of IronJS, but I think for now I'd like to build against the last stable code drop which was 0.2.

The Resharper naming is a good idea. I started this code using JS naming conventions (camel case) since the original code was actually written in JScript.NET and now that it is C# we should convert to Pascal naming.

@asbjornu
Copy link
Author

asbjornu commented Jul 1, 2011

Yea, just do a manual fetch and merge, and let me know how you want to move forward. I'll have a look at the test project soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants