Escape backslashes too #28
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc-vanderwal
force-pushed
the
bugfix/escape-backslashes-too
branch
from
5f5eb9b to
ab3a7c7
Compare
When a packet is received with a query for \\.test (that is, a name with two labels, one composed of only a backslash character, and the label “test”), labels_to_dname() decodes it to "\\.test". Calling dname_to_labels() again on that result yields \.test (that is, a name with one label, “.test”) instead of \\.test. The solution is to also backslash-escape the backslash character. This commit also adds corresponding unit tests to that effect.
NelsonVides
force-pushed
the
bugfix/escape-backslashes-too
branch
from
ab3a7c7 to
a2d82a8
Compare
Pull Request Test Coverage Report for Build 14396318806Details
💛 - Coveralls |
1 similar comment
Pull Request Test Coverage Report for Build 14396318806Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a packet is received with a query for
\\.test(that is, a name with two labels, one composed of only a backslash character, and the label “test”),labels_to_dname()decodes it to "\.test". Callingdname_to_labels()again on that result yields\.test(that is, a name with one label, “.test”) instead of\\.test.The solution is to also backslash-escape the backslash character.