Skip to content
This repository was archived by the owner on Jul 18, 2025. It is now read-only.

Conversation

@zelahi
Copy link
Contributor

@zelahi zelahi commented Sep 13, 2019

Signed-off-by: Zuhayr Elahi elahi.zuhayr@gmail.com

- What I did
Utilized the public fossa-analyzer image on hub

- How I did it
changed the references and removed calls to dockereng

- How to verify it
I ran the fossa-analyze and fossa-test locally

Also double checking it works as expected in the CI

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>
Copy link
Contributor

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Sep 16, 2019

Codecov Report

Merging #612 into master will decrease coverage by 0.67%.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #612      +/-   ##
==========================================
- Coverage   72.73%   72.05%   -0.68%     
==========================================
  Files          50       49       -1     
  Lines        2648     2559      -89     
==========================================
- Hits         1926     1844      -82     
+ Misses        486      484       -2     
+ Partials      236      231       -5
Impacted Files Coverage Δ
internal/commands/parameters.go 86.84% <ø> (-0.97%) ⬇️
internal/commands/upgrade.go 59.64% <ø> (-0.7%) ⬇️
internal/commands/cnab.go 72.14% <ø> (-0.13%) ⬇️
internal/commands/status.go 83.5% <100%> (+0.17%) ⬆️
internal/commands/install.go 66.66% <100%> (-0.46%) ⬇️
internal/version.go 78.57% <33.33%> (-14.29%) ⬇️
internal/commands/root.go 74.19% <80%> (+1.66%) ⬆️
internal/packager/init.go 60.97% <0%> (-8.18%) ⬇️
internal/packager/packing.go 53.19% <0%> (-4.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c9eb813...29f8fee. Read the comment docs.

checkout scm
ansiColor('xterm') {
sh "docker login -u $REGISTRY_USERNAME -p $REGISTRY_PASSWORD"
sh "FOSSA_API_KEY=$FOSSA_API_KEY BRANCH_NAME='${BRANCH_NAME}' make fossa-analyze"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unnecessary. withCredentials already expose FOSSA_API_KEY environment variable

Signed-off-by: Zuhayr Elahi <elahi.zuhayr@gmail.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants