Skip to content

[master] Bump compose v2.33.0#1163

Merged
thaJeztah merged 1 commit intodocker:masterfrom
ndeloof:bump_compose_v2.33.0
Feb 14, 2025
Merged

[master] Bump compose v2.33.0#1163
thaJeztah merged 1 commit intodocker:masterfrom
ndeloof:bump_compose_v2.33.0

Conversation

@ndeloof
Copy link
Copy Markdown
Contributor

@ndeloof ndeloof commented Feb 13, 2025

- What I did

Bump compose v2.33.0
Declare buildx as a recommended dependency as v2.33.0 introduces support for delegating build command to bake.

- How I did it

- How to verify it

- Description for the changelog

Compose v2.33.0

- A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
Copy link
Copy Markdown
Contributor

@vvoland vvoland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Package: docker-compose-plugin
Priority: optional
Architecture: linux-any
Recommends: docker-buildx-plugin
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Silly question; if compose shells out to buildx, and running as “standalone” (docker-compose) does it shell out to /whatever/path/for /plugins/docker-buildx (standalone) or docker buildx ? Mostly looking at Recommends: in the docker-compose-plugin package, and if that (when installed separate from the CLI) would also be able to use it, or if it should depend on docker-ce-cli already having the Recommends: for buildx

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compose executes the CLI plugin directly (standalone) based on binary file path retrieved from manager.GetPlugin.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha; thanks! Wanted to double-check we wouldn't end up in a case where the plug-in was there, but compose still trying to execute it in a different location.

We should probably look if we can have good ways for the CLI (when compose is executed as plugin) to pass information to the plugin(s), so that we have a single source of truth for resolving plugins, but that's an existing problem.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 240a045 into docker:master Feb 14, 2025
7 checks passed
@thaJeztah thaJeztah changed the title Bump compose v2.33.0 [master] Bump compose v2.33.0 Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants