Skip to content

[master] ci: Test more distros in GHA workflow#1178

Merged
thaJeztah merged 2 commits intodocker:masterfrom
vvoland:gha-distros
Apr 2, 2025
Merged

[master] ci: Test more distros in GHA workflow#1178
thaJeztah merged 2 commits intodocker:masterfrom
vvoland:gha-distros

Conversation

@vvoland
Copy link
Copy Markdown
Contributor

@vvoland vvoland commented Mar 28, 2025

Add distros from Jenkinsfile to GHA

@vvoland vvoland self-assigned this Mar 28, 2025
Add distros from Jenkinsfile to GHA

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland vvoland closed this Mar 31, 2025
@vvoland vvoland reopened this Mar 31, 2025
@vvoland vvoland requested a review from thaJeztah March 31, 2025 17:30
@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Apr 2, 2025

@thaJeztah LGTY?

@thaJeztah
Copy link
Copy Markdown
Member

Oh! Looks like we didn't update this repository yet to use ubuntu 24.04 (so it will start failing soon);

runs-on: ubuntu-20.04

@thaJeztah
Copy link
Copy Markdown
Member

Changes LGTM overall;

  • Should we copy the "EOL" date comments to this file as well? (it's useful to have those as a reminder when distros become EOL)
  • Should we start removing distros from the Jenkinsfile? Or do we want the internal ("release packaging") repository to be updated first (i.e., have this repository also run in the Jenkins environment in case they're different).

@thaJeztah
Copy link
Copy Markdown
Member

Also (bit orthogonal, and definitely for separate); I was considering if we should group builds per architecture so that we could potentially make use of caching. Currently I don't think it makes a lot of difference (as the builds happen in a docker run), but if we at some point rewrite them to be done in a docker build, we may be able to take advantage of some caching.

@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Apr 2, 2025

I'd keep the Jenkins file as the source of truth for now. Let's avoid putting the "EOL" comments in two places - there's already too many repos we have to go through for packaging different distros 🙈

@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Apr 2, 2025

Currently the workflow only tests the amd64 so there's nothing much to group (yet).

ubuntu-20 will be removed soon

Signed-off-by: Paweł Gronowski <pawel.gronowski@docker.com>
@vvoland
Copy link
Copy Markdown
Contributor Author

vvoland commented Apr 2, 2025

Sneaked in a commit to bump the ubuntu to 24

@thaJeztah
Copy link
Copy Markdown
Member

Let's avoid putting the "EOL" comments in two places

Yeah, this was with the idea in mind if we'd remove them from Jenkins; we can do it when we do that.

Copy link
Copy Markdown
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit e11f8c1 into docker:master Apr 2, 2025
12 checks passed
@thaJeztah thaJeztah changed the title ci: Test more distros in GHA workflow [master] ci: Test more distros in GHA workflow Apr 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants