RPM: require "iptables-nft or iptables"#1263
Merged
vvoland merged 1 commit intodocker:masterfrom Oct 7, 2025
Merged
Conversation
Rather than requiring iptables-nft for RHEL10/Fedora43 and iptables for other versions and CentOS, use "(iptables-nft or iptables)". Signed-off-by: Rob Murray <rob.murray@docker.com>
vvoland
approved these changes
Oct 7, 2025
Contributor
vvoland
left a comment
vvoland
left a comment
There was a problem hiding this comment.
LGTM
For a follow up, I think we could do the same (iptables | nftables) for debs, right?
docker-ce-packaging/deb/common/control
Lines 29 to 30 in 4fe9f66
Contributor
Author
I looked in to that, it doesn't seem to be needed because on Debian the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- What I did
Rather than requiring iptables-nft for RHEL10/Fedora43 and iptables for other versions and CentOS, use "(iptables-nft or iptables)".
Newer OSs will have iptables-nft, if anything - and making people install iptables-legacy isn't great if it's not needed.
(When neither dependency is available - dnf seems to install both if they're available, but doesn't mind if it can only find one of them. And, if one's already installed, it doesn't try to install the other.)
- Description for the changelog