Skip to content

Conversation

@dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Nov 19, 2025

@netlify
Copy link

netlify bot commented Nov 19, 2025

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 13e9e4e
🔍 Latest deploy log https://app.netlify.com/projects/docsdocker/deploys/69304763d2de2f000815ef7e
😎 Deploy Preview https://deploy-preview-23745--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added area/release Relates to CI or deployment ci ci updates labels Nov 19, 2025
@dvdksn dvdksn force-pushed the reusable-workflow branch 4 times, most recently from 64d83ee to 4d36da3 Compare November 19, 2025 18:01
@dvdksn dvdksn force-pushed the reusable-workflow branch from 4d36da3 to d80ccdb Compare December 3, 2025 12:36
@dvdksn dvdksn force-pushed the reusable-workflow branch 9 times, most recently from 15ce257 to c5a6cdb Compare December 3, 2025 14:05
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
@dvdksn dvdksn force-pushed the reusable-workflow branch from c5a6cdb to 13e9e4e Compare December 3, 2025 14:21
target = "aws-cloudfront-update"
contexts = {
sitedir = DOCS_SITE_DIR
sitedir = "target:release"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crazy-max ptal at this. Not sure if this is something we should support.

The aws-cloudfront-update target was preceded by a release build:

https://github.com/docker/docs/pull/23745/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721L45-L69

The sitedir arg was used to bind mount the public directory into the build, from the local context:

https://github.com/dvdksn/docs/blob/13e9e4e4dd7a0ed54d53ba0996100809b0ce5c90/hack/releaser/Dockerfile#L40

So I changed the sitedir per above, to bind mount the build results from the release stage directly. But that doesn't work with the reusable workflow since we only allow building a single target at once:

https://github.com/docker/docs/actions/runs/19897113629/job/57030322616?pr=23745#step:4:184

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config area/release Relates to CI or deployment ci ci updates

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant