Release profiles as the default. #260
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if len(options.CatalogPath) == 0 && len(options.RegistryPath) == 0 && len(options.ConfigPath) == 0 && len(options.ToolsPath) == 0 { | ||
| // We're in working set mode, so use the default profile if no profile is specified | ||
| if options.WorkingSet == "" { | ||
| options.WorkingSet = "default" | ||
| } | ||
| } | ||
|
|
||
| if options.WorkingSet != "" && | ||
| (len(options.ServerNames) > 0 || enableAllServers || | ||
| len(options.CatalogPath) > 0 || len(options.RegistryPath) > 0 || len(options.ConfigPath) > 0 || len(options.ToolsPath) > 0 || | ||
| len(additionalCatalogs) > 0 || len(additionalRegistries) > 0 || len(additionalConfigs) > 0 || len(additionalToolsConfig) > 0 || | ||
| len(mcpRegistryUrls) > 0 || len(options.OciRef) > 0 || | ||
| options.SecretsPath != "docker-desktop") { |
There was a problem hiding this comment.
The new defaulting to options.WorkingSet="default" fires whenever the catalog/registry/config/tools paths are empty (lines 67-70), but it ignores other configuration flags such as --additional-catalog, --additional-config, --additional-registry, --additional-tools-config, or --mcp-registry. On a host run the subsequent guard at lines 74-79 then rejects the run because a profile is now set, so commands like docker mcp gateway run --additional-catalog foo.yaml or --mcp-registry … fail even though the user never asked for a profile. This blocks non-profile usage whenever any of those flags are provided. The default profile should be skipped when any extra catalog/registry/config inputs are supplied.
Useful? React with 👍 / 👎.
What I did
catalogcommand is nowcatalog-deprecatedand is hidden.catalog-nextsubcommand is nowcatalog.docker mcp gateway runwill now default to attempting to run the profile with iddefault--profilea required flag fordocker mcp client connectImportant
Do not merge until we are ready to release this breaking change.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did