Skip to content

Conversation

@vagenas
Copy link
Collaborator

@vagenas vagenas commented Oct 21, 2025

Main goal has been to establish metadata model that:

  • allows both prescribed and custom fields, with a way to distinguish the two
  • allows both common and type-specific fields, so that we can further specify the metadata reqs e.g. for PictureItem
  • accounts for serialization and deserialization, e.g. ideally avoiding serializing additional data if no meta info available

@mergify
Copy link

mergify bot commented Oct 21, 2025

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 Require two reviewer for test updates

This rule is failing.

When test data is updated, we require two reviewers

  • #approved-reviews-by >= 2

🟢 Enforce conventional commit

Wonderful, this rule succeeded.

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:\(.+\))?(!)?:

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

❌ Patch coverage is 95.34884% with 12 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
docling_core/types/doc/document.py 92.85% 9 Missing ⚠️
docling_core/transforms/serializer/html.py 92.30% 2 Missing ⚠️
docling_core/transforms/serializer/markdown.py 96.96% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 21, 2025

DCO Check Passed

Thanks @vagenas, all your commits are properly signed off. 🎉

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
…for summaries

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
…amless chunking integration

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
@vagenas vagenas marked this pull request as ready for review October 28, 2025 22:36
@dosubot
Copy link

dosubot bot commented Oct 28, 2025

Related Documentation

Checked 3 published document(s). No updates required.

How did I do? Any feedback?  Join Discord

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
PeterStaar-IBM
PeterStaar-IBM previously approved these changes Oct 29, 2025
Copy link
Contributor

@PeterStaar-IBM PeterStaar-IBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

However, it would be good to update the init.py with the newly introduced classes.

class TabularChartMetaField(BasePrediction):
"""Tabular chart metadata field."""

title: str
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's quickly check on this

Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Signed-off-by: Panos Vagenas <pva@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants