Fix crash when parsing manual pokefam combat#10
Open
Donald-Lafleur wants to merge 1 commit intodocrostov:mainfrom
Open
Fix crash when parsing manual pokefam combat#10Donald-Lafleur wants to merge 1 commit intodocrostov:mainfrom
Donald-Lafleur wants to merge 1 commit intodocrostov:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A fairly recent update to KoLmafia that improved pokefam combat logging also broke ScotchLog parsing of pokefam logs. The updated pokefam combat logs have the format
%playername%'s %pokefam% uses %skill%!where there was nothing before. This causes an unconditional out of bounds array access after splitting a combat round string with a substring it doesn't contain.I assume that combat log rounds from pokefam with the new format won't have things worth tracking here. Most of my logs are just
Slotter uses ULTIMATE: Blood Bath!round 1 of every combat after getting it to level 5. If somehow a normal combat leaked into pokefam that allowed combat skills or item usage then the combat logs should still be parsed normally.