Skip to content

Fix crash when parsing manual pokefam combat#10

Open
Donald-Lafleur wants to merge 1 commit intodocrostov:mainfrom
Donald-Lafleur:pokefams
Open

Fix crash when parsing manual pokefam combat#10
Donald-Lafleur wants to merge 1 commit intodocrostov:mainfrom
Donald-Lafleur:pokefams

Conversation

@Donald-Lafleur
Copy link

A fairly recent update to KoLmafia that improved pokefam combat logging also broke ScotchLog parsing of pokefam logs. The updated pokefam combat logs have the format %playername%'s %pokefam% uses %skill%! where there was nothing before. This causes an unconditional out of bounds array access after splitting a combat round string with a substring it doesn't contain.

I assume that combat log rounds from pokefam with the new format won't have things worth tracking here. Most of my logs are just Slotter uses ULTIMATE: Blood Bath! round 1 of every combat after getting it to level 5. If somehow a normal combat leaked into pokefam that allowed combat skills or item usage then the combat logs should still be parsed normally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant