Improved cheat copying and select or fill operation.#9
Open
JohnWilliston wants to merge 1 commit intodoctorfree:masterfrom
Open
Improved cheat copying and select or fill operation.#9JohnWilliston wants to merge 1 commit intodoctorfree:masterfrom
JohnWilliston wants to merge 1 commit intodoctorfree:masterfrom
Conversation
I'm guessing a bit as to the plugin author's intentions, but for my use case I find the functions to copy the cheat and more tellingly the function to `select_or_fill_commandline` to be less than ideal. It seems the author intended the former to copy the cheat code for easy subsequent use but was copying only to the "0" register, which seems to copy only to the " register and not more clipboard friendly registers. I've changed this to include * as well. And in both cases I've changed the author's use of the `vim.api.nvim_echo` method to add to message history because the text doesn't appear anywhere at all if I don't. At least that way I can review it in the message history.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing a bit as to the plugin author's intentions, but for my use case I find the functions to copy the cheat and more tellingly the function to
select_or_fill_commandlineto be less than ideal. It seems the author intended the former to copy the cheat code for easy subsequent use but was copying only to the "0" register, which seems to copy only to the " register and not more clipboard friendly registers. I've changed this to include * as well. And in both cases I've changed the author's use of thevim.api.nvim_echomethod to add to message history because the text doesn't appear anywhere at all if I don't. At least that way I can review it in the message history.