Open
Conversation
greg0ire
reviewed
Jan 14, 2024
greg0ire
reviewed
Jan 14, 2024
| $contents | ||
| ); | ||
|
|
||
| $expected = '<p>Reference is <a href="page2.html#reference-one">here</a></p>'; |
Member
There was a problem hiding this comment.
For anyone wondering, the bug is that without @alamirault 's changes, instead of page2.html, page1.html is used.
Member
|
It seems there are CI jobs failing. Please take a look at this guide for more on how to handle those. |
Author
|
@greg0ire I fixed code style, pipeline should be green now |
greg0ire
approved these changes
Jan 28, 2024
SenseException
approved these changes
Jan 28, 2024
| .. _reference-one: | ||
|
|
||
| ``one`` | ||
| ~~~~~~~~~~~ No newline at end of file |
Member
There was a problem hiding this comment.
I didn't know that GitHub highlights a missing newline at the end of a file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try fix #275