Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mattprintz this is not ready for a PR since I have not tested this at all...I mostly just wanted to use this as a means to get your thoughts on this approach.
My simple idea here (how can we make this more automated?!) is this:
models.pyto test a model by creating a default run.utils.pyto do the default run for the model and store that info to atestsES indexruns.pywhich checks the status of test runs and updatestestsindex if the status is nowsuccessorfailure(instead of running)We'd basically run 2 crons:
/models/testfor each modelmodel_idthat ispublished. Write therun_idsto a log filetest_runs.logtest_runs.logand submits to/runs/testfor eachrun_idWe'd then update the model overview page in the UI to add a column for the test run status.