[Refactor] Handling exceptions on execute raw#53
Open
cristianFleita wants to merge 3 commits intodojoengine:mainfrom
Open
[Refactor] Handling exceptions on execute raw#53cristianFleita wants to merge 3 commits intodojoengine:mainfrom
cristianFleita wants to merge 3 commits intodojoengine:mainfrom
Conversation
Larkooo
reviewed
Jun 28, 2024
| } | ||
| catch (Exception e) | ||
| { | ||
| Debug.LogError($"Error in ExecuteRaw: {e.Message}"); |
Collaborator
There was a problem hiding this comment.
I feel like if we end up wrapping the error by a try on the JS side and returning a Result then we shouldn't even throw. Since we wouldn't necessarily want to stop the game loop just because a transaction failed. We could maybe make ExecuteRaw return if the transaction failed?
Contributor
Author
There was a problem hiding this comment.
Oh yes, you got a point.
I could wrap the result of the execution on this class:
public class Result<T>
{
public bool IsSuccess { get; }
public T Value { get; }
public string Error { get; }
private Result(T value, string error, bool isSuccess)
{
Value = value;
Error = error;
IsSuccess = isSuccess;
}
public static Result<T> Success(T value) => new Result<T>(value, null, true);
public static Result<T> Failure(string error) => new Result<T>(default(T), error, false);
}What do you think?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances exception handling in the WebGL implementation of the executeRaw function and updates the AccountExecuteRawHelper class to improve callback handling.
Changes Made