Part 1 - Match Sato/StringObj #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This particular piece of code was lifted from an existing implementation of the Legend of Zelda: Skyward Sword decompilation project. This function is just getNthLink() without the need to cast the object's type manually, as it's implied through the data type provided in the declaration via templates.
… the matrix class. The `getYDirInline()` inline function is used the in `StringObj::calc()` function, and after a quick GitHub search I've seen a similar implementation for these inlines also exist in the [Super Mario Galaxy (Petari) Decomp](https://github.com/SMGCommunity/Petari/blob/33b64d162c02fc6e027c874a3a23216d6fb40376/libs/JSystem/include/JSystem/JGeometry/TMatrix.hpp#L211).
… match accuracy.
Report for MarioClub_us (f87ed4d - 4c508c6)📈 Matched code: 42.56% (+0.12%, +3872 bytes) ✅ 25 new matches
📈 8 improvements in unmatched functions
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what I've managed to decompile for the StringObj class. I still have some work to do on matching other functions, but this at least sets up the basic class structure and a few key functions.
Creating this PR in response to another function @SwareJonge is currently working on decompiling so as to avoid merge conflicts.