dolthub/dolt#9812: Coalesce IN and = operator logic
#3204
Merged
+126
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianddb
force-pushed
the
elian/9812
branch
4 times, most recently
from
c621c6d to
e79fbd7
Compare
elianddb
changed the title
IN and = operator logic
elianddb
force-pushed
the
elian/9812
branch
2 times, most recently
from
4adff84 to
c0b49b2
Compare
elianddb
force-pushed
the
elian/9812
branch
3 times, most recently
from
2e6c03b to
d4532fb
Compare
elianddb
force-pushed
the
elian/9812
branch
from
0977da2 to
17c53ae
Compare
elianddb
force-pushed
the
elian/9812
branch
from
cdd4338 to
e27a016
Compare
elianddb
force-pushed
the
elian/9812
branch
from
4094693 to
38d8d4f
Compare
| @@ -120,6 +121,115 @@ type ScriptTestAssertion struct { | |||
| // Unlike other engine tests, ScriptTests must be self-contained. No other tables are created outside the definition of | |||
| // the tests. | |||
| var ScriptTests = []ScriptTest{ | |||
| { | |||
| // https://github.com/dolthub/dolt/issues/9836 | |||
| Name: "Ordering by pk does not change the order of results", | |||
There was a problem hiding this comment.
For these tests, can you update to "select pk from test order by pk"? we don't need to test for casting here. You can also simplify the test to just include the 7 values
There was a problem hiding this comment.
You can also tag the entire test with Skip, instead of individual assertions
elianddb
force-pushed
the
elian/9812
branch
from
bdd8955 to
9fc0d7e
Compare
elianddb
force-pushed
the
elian/9812
branch
from
c773cba to
1031166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dolthub/dolt#9812