Support for default units in the parser if no unit has been specified. #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Test cases added. |
Owner
|
Nice! Sorry it’s taken me a while to get back to you on this. If you squash your commits, I’ll get this merged. Thanks! |
Owner
|
Also the default units To Do can be removed from the README |
|
Whats the deal with this...I want want to use it! |
igitur
force-pushed
the
parser_default_units
branch
from
cb1a1f4 to
5514aa6
Compare
Author
|
Sorry, I kind of forgot about this. Commits are squashed and README updated. All tests pass. |
|
For anyone interested in this (why is it not merged yet?). It's merged in this fork |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the parser to assume a certain unit if no units were specified in the input string.