-
Notifications
You must be signed in to change notification settings - Fork 0
[EPIC-6378] Prepare/restructure for stable RC #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… sync across Java/Python/C wrappers
Add snippets for nodejs wrapper
… commens and separated functions
…s for scanner/result/etc.
examples/c/src/snippets/datacapture/medical_certificate_scanner.c
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/barcode/DetectBarcodesSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/datacapture/CheckScannerSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/datacapture/CreditCardScannerSnippet.java
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/license/FloatingLicenseSnippet.java
Outdated
Show resolved
Hide resolved
examples/java/src/main/java/io/scanbot/sdk/snippets/license/FloatingLicenseSnippet.java
Outdated
Show resolved
Hide resolved
examples/python/minimal/snippets/barcode/barcode_document_parser.py
Outdated
Show resolved
Hide resolved
examples/python/minimal/snippets/document/analyse_multi_page.py
Outdated
Show resolved
Hide resolved
examples/nodejs/README.md
Outdated
|
||
## Setup | ||
|
||
1. Go to [GitHub Releases](https://github.com/doo/scanbot-sdk-example-linux/releases) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no need to manually install addon. The customer should only install corresponding mpm package. The addon will be downloaded and installed automatically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated within npm install
examples/nodejs/package.json
Outdated
"typescript": "^5.9.2" | ||
}, | ||
"dependencies": { | ||
"scanbotsdk": "file:scanbotsdk-20.0.16.tgz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we specify url to the npm package here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
examples/nodejs/package.json
Outdated
@@ -0,0 +1,20 @@ | |||
{ | |||
"name": "nodejs", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably something like scanbotsdk_nodejs_example (not sure about case convention here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
renamed
} | ||
|
||
private static printResult(page: ScanbotSDK.Page): void { | ||
if (page.blocks) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need for these ifs I believe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
condition removed
export class TextPatternScannerSnippet { | ||
public static async run(image: ScanbotSDK.ImageRef): Promise<void> { | ||
const config = new ScanbotSDK.TextPatternScannerConfiguration(); | ||
config.minimumNumberOfRequiredFramesWithEqualScanningResult = 2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't be 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated to 1
filePath: string | ||
): Promise<ScanbotSDK.PageExtractionResult> { | ||
return await ScanbotSDK.autorelease(async () => { | ||
const source = await ScanbotSDK.RandomAccessSource.fromPath(filePath); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await using source =
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with await using
): Promise<ScanbotSDK.PageExtractionResult> { | ||
return await ScanbotSDK.autorelease(async () => { | ||
const source = await ScanbotSDK.RandomAccessSource.fromPath(filePath); | ||
const extractor = await ScanbotSDK.MultiPageImageExtractor.create(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
await using extractor =
... autorelease pool works only for images
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replaced with await using
examples/python/README.md
Outdated
* Install the Scanbot SDK package | ||
### 4. Download and install the Scanbot SDK | ||
1. Go to [GitHub Releases](https://github.com/doo/scanbot-sdk-example-linux/releases) | ||
2. Manually download the **Python package** for your platform (ARM64 or x86_64). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pip supports install from url, no need to manually download wheels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated withing pip install usage
|
||
### ⚡ Performance notes (Jetson) | ||
To avoid throttling, set max GPU/CPU/memory clocks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need this note for all the wrappers which support live mode, i.e. for c as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated c wrapper readme with this part
examples/java/README.md
Outdated
|
||
### Setup | ||
1. Go to [GitHub Releases](https://github.com/doo/scanbot-sdk-example-linux/releases) | ||
2. Manually download the **Jar package** for your platform (ARM64 or x86_64). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should it be manually downloaded? In the previous example it was automatically downloaded bu gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated build.gradle
No description provided.