Skip to content

new classifier#8

Open
idriss-hamadi wants to merge 2 commits intodorahacksglobal:mainfrom
idriss-hamadi:main
Open

new classifier#8
idriss-hamadi wants to merge 2 commits intodorahacksglobal:mainfrom
idriss-hamadi:main

Conversation

@idriss-hamadi
Copy link
Copy Markdown

@idriss-hamadi idriss-hamadi commented Jun 3, 2024

#3 provides

@sid-chava sid-chava self-requested a review June 3, 2024 22:09
Copy link
Copy Markdown
Contributor

@sid-chava sid-chava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is definitely a really good start. The approach to optimizing features is interesting and shows promise. However, we have concerns about potential overfitting due to the oversampling technique used. Is there anyway you would be able to isolate the improvements without oversampling? I understand that the accuracy jump may not be as high but we are interested to see if the feature tweaks you made were able to generate improvements.

@idriss-hamadi
Copy link
Copy Markdown
Author

yes i double checked , by repeating some code i caused some data leakage which caused the model to test on data it already have seen, now that i changed the approach, i will make a PR with another notebook

@idriss-hamadi
Copy link
Copy Markdown
Author

now that i added a new file, i read from a comment that the rows with label 1 are generated with a simulator, so i dropped the rows of it and continued working with the other 3 remaining targets, i added more pre-processing functions and different modeling, so far for this the model has on average 72% accuracy

i also tried different approach of one vs all approach , when i try to predict if this sequence is generated by a specific class or not (binary classification)

i had average results of

77% accuracy when predicting 4 vs all
84% accuracy when predicting 3 vs all
84% accuracy when predicting 2 vs all

so I'm currently working on lowering the rate of misclassification in the model

any review would be appreciated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants