Add new analyzer to detect invalid Frame.Navigate calls#261
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new WinUIEx Roslyn analyzer that flags Frame.Navigate(typeof(...)) calls where the provided type does not derive from Microsoft.UI.Xaml.Controls.Page, preventing a known runtime crash scenario (Issue #260).
Changes:
- Introduces analyzer rule WinUIEx1003 to validate
Frame.Navigate(Type)target types at compile time. - Adds rule documentation + localized resources and ships the rule in the analyzer release manifest.
- Adds analyzer unit tests, bumps package version, and updates
.gitignore.
Reviewed changes
Copilot reviewed 7 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/WinUIEx/WinUIEx.csproj | Updates package release notes to mention the new analyzer. |
| src/WinUIEx.Analyzers/WinUIEx.Analyzers/WinUIExFrameNavigateAnalyzer.cs | Implements WinUIEx1003 diagnostic for invalid Frame.Navigate(Type) target types. |
| src/WinUIEx.Analyzers/WinUIEx.Analyzers/Resources.resx | Adds localized strings for WinUIEx1003 title/message/description. |
| src/WinUIEx.Analyzers/WinUIEx.Analyzers/Resources.Designer.cs | Regenerates resource accessors for the new WinUIEx1003 strings. |
| src/WinUIEx.Analyzers/WinUIEx.Analyzers/AnalyzerReleases.Shipped.md | Records WinUIEx1003 as a shipped analyzer rule. |
| src/WinUIEx.Analyzers/WinUIEx.Analyzers.Test/WinUIExFrameNavigateAnalyzerTests.cs | Adds unit tests covering valid/invalid Frame.Navigate(typeof(...)) usage. |
| src/Directory.Build.targets | Bumps package version to 2.9.1. |
| docs/rules/WinUIEx1003.md | Adds documentation page for the new analyzer rule. |
| .gitignore | Ignores local .dotnet directory. |
Files not reviewed (1)
- src/WinUIEx.Analyzers/WinUIEx.Analyzers/Resources.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issue: #260
Closes #
PR Type
Summary
Validation
Notes