Skip to content

Bodysite bugfix#126

Merged
jenniferjiangkells merged 1 commit intomainfrom
bugfix/bodysite_code
May 13, 2025
Merged

Bodysite bugfix#126
jenniferjiangkells merged 1 commit intomainfrom
bugfix/bodysite_code

Conversation

@adamkells
Copy link
Contributor

Description

The Faker random element method requires a tuple provided with more than one element. If one string is provided, it chooses a random character from the string. This PR fixes the issue by adding commas to the set of elements.

Related Issue

#115

Changes Made

Added two commas to select element from tuple properly

Testing

Tested the Faker function locally.

Checklist

  • I have read the contributing guidelines
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Additional Notes

@adamkells adamkells self-assigned this May 10, 2025
Copy link
Member

@jenniferjiangkells jenniferjiangkells left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jenniferjiangkells jenniferjiangkells linked an issue May 13, 2025 that may be closed by this pull request
@jenniferjiangkells jenniferjiangkells merged commit 9491826 into main May 13, 2025
8 checks passed
@jenniferjiangkells jenniferjiangkells deleted the bugfix/bodysite_code branch May 13, 2025 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BodySite code not generated properly

2 participants