fixed: Remove null values from CDS Hook API responses #142#147
Merged
adamkells merged 6 commits intodotimplement:mainfrom Oct 13, 2025
Merged
Conversation
adamkells
requested changes
Oct 5, 2025
Contributor
adamkells
left a comment
There was a problem hiding this comment.
Hi! Thanks for the effort on this! Just two things:
- It looks like you committed the .idea folder from your IDE by mistake, can you remove this?
- The issue had a script to run for confirming that the changes are correct, (it's the very last line) can you trying running that also?
adamkells
approved these changes
Oct 13, 2025
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the issue "Remove null values from CDS Hook API responses #142".
Related Issue
Remove null values from CDS Hook API responses #142
Changes Made
exclude_none=Truetomodel_dump()at healthchain/gateway/events/dispatcherexclude_none=Truetomodel_dump()at /gateway/fhir/aio.pyexclude_none=Truetomodel_dump()at healthchain/gateway/fhir/base.pyexclude_none=Truetomodel_dump()at healthchain/interop/generators/cda.pyexclude_none=Truetomodel_dump()at tests/gateway/test_base_fhir_gateway.pyexclude_none=Truetomodel_dump()at tests/gateway/test_event_dispatcher.pyTesting
poetry run pytestChecklist
Additional Notes