feat: Clarify FhirData setter behavior with explicit replace parameter and transition to uv#149
Merged
adamkells merged 12 commits intodotimplement:mainfrom Dec 10, 2025
Merged
Conversation
2 tasks
adamkells
reviewed
Oct 31, 2025
jenniferjiangkells
previously approved these changes
Dec 2, 2025
Contributor
|
@jenniferjiangkells The issue with the slow CI testing for 3.9 python has been confirmed to be the result of spacy/thinc removing pre-built wheels for Python 3.9. It is still not clear why the same issue didn't arise for poetry/pip installation and only uv. It is possible that these wheels are cached across jobs and so still available to the CI run. Either way I have removed support for python 3.9 as it is EOL. |
jenniferjiangkells
approved these changes
Dec 9, 2025
adamkells
approved these changes
Dec 10, 2025
Contributor
Author
|
Thanks! @adamkells and @jenniferjiangkells |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarifies the behavior of resource list setters in the FhirData class by adding explicit control over whether they add to or replace existing resources.
Also transition from poetry to uv as dependency manager.
Related Issue
Closes #123 - Clarify Resource List Setter Behavior in FhirData
Changes Made
Testing
Checklist
Additional Notes
The implementation uses a dict-based approach for the replace parameter since Python property setters can only accept a single value argument. This provides explicit control while maintaining full backward compatibility with existing code.