Skip to content

[3.0] OpenAL Bindings #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 45 commits into
base: develop/3.0
Choose a base branch
from
Open

[3.0] OpenAL Bindings #2494

wants to merge 45 commits into from

Conversation

@Perksey
Copy link
Member

@Perksey Perksey commented Sep 30, 2025 •
edited
Loading

Uses the OpenAL Soft XML registry and headers.

TODO:

  • Fix *Direct not having data types trimmed
  • OpenAL Soft native builds
  • Example
  • Single enum groups still have al/alc prefix
  • Where's the EFX at?

@Perksey Perksey mentioned this pull request Sep 30, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Sep 30, 2025 •
edited
Loading

File Coverage
All files 3% ✅

Minimum allowed coverage is 0%

Generated by 🐒 cobertura-action against 07c5176

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025 •
edited
Loading

All native library builds modified in this PR shall attempt to be built by CI.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025 •
edited
Loading

All native library builds modified in this PR shall attempt to be built by CI.

Perksey
Perksey commented Nov 10, 2025
View reviewed changes
@Perksey Perksey mentioned this pull request Nov 11, 2025
Merged
@github-actions
Copy link
Contributor

github-actions bot commented Nov 11, 2025 •
edited
Loading

Some of the native library builds modified in this PR were not referenced in the PR description. Please ensure that the PR description contains /build-native OpenAL-Soft SDL. These libraries won't be rebuilt without this being specified. If you believe this is in error, then please write a comment explaining why and ignore this suggestion. This comment will be automatically updated if rectified.

@Perksey
Copy link
Member Author

Perksey commented Nov 11, 2025

Ignore the bot, I have committed new CI-built binaries previously :)

@Perksey
Copy link
Member Author

Perksey commented Nov 11, 2025

Ready for review. Note the outstanding question.

@Perksey Perksey marked this pull request as ready for review November 11, 2025 18:59
@Perksey Perksey requested a review from a team as a code owner November 11, 2025 18:59
Exanite
Exanite reviewed Nov 12, 2025
View reviewed changes
Exanite
Exanite reviewed Nov 12, 2025
View reviewed changes
@Perksey Perksey requested a review from curin November 13, 2025 21:02
@Perksey Perksey moved this from Todo to In Progress in Silk.NET Development Tracker Nov 13, 2025
@Exanite
Copy link
Contributor

Exanite commented Nov 14, 2025 •
edited
Loading

I didn't look at LoaderInterface and ChangeNativeClass closely, but everything looks fine from my light review of the code. I also didn't look at the OpenAL binding outputs.
Also, for anyone else looking through the code, all of the OpenGL enum changes are commas, except for the two (one?) that Perksey commented on.

@Perksey
Copy link
Member Author

Perksey commented Nov 15, 2025

Awesome, just needs a @curin review and we can get this merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@curin curin Awaiting requested review from curin

1 more reviewer

@Exanite Exanite Exanite left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@curin curin

Labels

None yet

Projects

Silk.NET Development Tracker
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Perksey @Exanite @curin @dotnet-bot