Fix post actions for Razor Class Library template #64532
+17
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Razor Class Library template has an option, `SupportsPagesAndViews` that causes it to produce one of two sets of files. If true, then `Areas/MyFeature/Pages/Page1.cshtml` is created. If false, then `Component1.razor` is created. The issue with the previous template is that the set of primary outputs and the corresponding `openInEditor` post-actions were not taking this option into account, and were always trying to open the `Page1.cshtml` file, even if it didn't exist on disk. This led to the bug described in microsoft/vscode-dotnettools#2489 C# Dev Kit has been patched to not show warnings when a template specifies that non-existent files should be opened. With the change here, users creating this template will now see the correct file opened. This applies both to VS and CDK.
github-actions
bot
added
the
area-mvc
davidwengier
approved these changes
Nov 26, 2025
Copilot finished reviewing on behalf of
drewnoakes
November 26, 2025 02:53
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug in the Razor Class Library template where post-actions were attempting to open files that didn't exist. The template supports two modes controlled by the SupportPagesAndViews parameter: when true, it creates Areas/MyFeature/Pages/Page1.cshtml; when false, it creates Component1.razor. Previously, the template always tried to open Page1.cshtml regardless of which mode was used.
Key changes:
- Added conditional logic to
primaryOutputsto specify the correct file based onSupportPagesAndViewsparameter - Added a new
openInEditorpost-action for theComponent1.razorfile with appropriate conditions - Updated the existing
openInEditorpost-action forPage1.cshtmlto only apply whenSupportPagesAndViewsis true
Member
Author
|
I can't see how the pipeline failures are related to this change. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Razor Class Library template has an option,
SupportsPagesAndViewsthat causes it to produce one of two sets of files. If true, thenAreas/MyFeature/Pages/Page1.cshtmlis created. If false, thenComponent1.razoris created.The issue with the previous template is that the set of primary outputs and the corresponding
openInEditorpost-actions were not taking this option into account, and were always trying to open thePage1.cshtmlfile, even if it didn't exist on disk.This led to the bug described in microsoft/vscode-dotnettools#2489
C# Dev Kit has been patched to not show warnings when a template specifies that non-existent files should be opened.
With the change here, users creating this template will now see the correct file opened. This applies both to VS and CDK.