Extend MinimalPermissionsGuidancePlugin with scopes to ignore #1365
Conversation
…nitializeApiSpecsFolderPath
There was a problem hiding this comment.
Thanks for the PR. Let's do some changes before we proceed. Since quite a few things changed, I'll have a more thorough look at it in the week of Aug 25. For the future, let's keep PRs focused on the issue at hand and avoid unrelated refactorings. If you see room for improvement, please raise an issue so that we can discuss it first 🙂
| @@ -8,6 +8,14 @@ | |||
| }, | |||
| "apiSpecsFolderPath": { | |||
| "type": "string" | |||
| }, | |||
| "permissionsToExclude": { | |||
There was a problem hiding this comment.
Since we're just adding this property, we can't update previous versions schemas because the property isn't available there. Let's only add it to the latest version
DevProxy.Plugins/Utils/GraphUtils.cs
Outdated
| @@ -96,4 +101,57 @@ internal async Task<IEnumerable<string>> UpdateUserScopesAsync(IEnumerable<strin | |||
|
|
|||
| return newMinimalScopes; | |||
| } | |||
|
|
|||
| public static MethodAndUrl GetMethodAndUrl(string methodAndUrlString) | |||
There was a problem hiding this comment.
This method doesn't need to be public. Let's make it internal instead
DevProxy.Plugins/Utils/GraphUtils.cs
Outdated
| return new(Method: info[0], Url: info[1]); | ||
| } | ||
|
|
||
| public static string GetTokenizedUrl(string absoluteUrl) |
There was a problem hiding this comment.
This method doesn't need to be public. Let's make it internal instead
DevProxy.Plugins/Utils/GraphUtils.cs
Outdated
| return "/" + string.Concat(new Uri(sanitizedUrl).Segments.Skip(2).Select(Uri.UnescapeDataString)); | ||
| } | ||
|
|
||
| public static MethodAndUrl[] GetRequestsFromBatch(string batchBody, string graphVersion, string graphHostName) |
There was a problem hiding this comment.
This method doesn't need to be public. Let's make it internal instead
DevProxy.Plugins/Utils/GraphUtils.cs
Outdated
| @@ -96,4 +101,57 @@ internal async Task<IEnumerable<string>> UpdateUserScopesAsync(IEnumerable<strin | |||
|
|
|||
| return newMinimalScopes; | |||
| } | |||
|
|
|||
| public static MethodAndUrl GetMethodAndUrl(string methodAndUrlString) | |||
There was a problem hiding this comment.
This method isn't related to Graph so let's find a better place for it
There was a problem hiding this comment.
Moved to MethodAndUrlUtils.
(the method is consumed by graph plugings)
At the beginning it seemed like we needed those changes for Graph-related classes. |
#1052