Add bounding box scaling note#24884
Merged
luisquintanilla merged 11 commits intodotnet:mainfrom Jul 7, 2021
Merged
Conversation
luisquintanilla
requested review from
JakeRadMSFT,
LittleLittleCloud and
briacht
Youssef1313
reviewed
Jun 28, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jun 28, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jun 28, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jun 28, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
Youssef1313
reviewed
Jun 28, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
Thanks Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Co-authored-by: Youssef Victor <youssefvictor00@gmail.com>
Contributor
Author
|
Closing and reopening |
Contributor
Author
|
@JakeRadMSFT @LittleLittleCloud ready for review when you get a chance. Thanks |
LittleLittleCloud
approved these changes
Jun 29, 2021
briacht
reviewed
Jul 1, 2021
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
docs/machine-learning/tutorials/object-detection-model-builder.md
Outdated
Show resolved
Hide resolved
| > 1. Multiply top and bottom coordinates by the original image height, and multiply left and right coordinates by the original image width. | ||
| > 1. Divide top and bottom coordinates by 600, and divide left and right coordinates by 800. | ||
| > | ||
| > For example, given the original image dimensions,`actualImageHeight` and `actualImageWidth`, and a prediction `prediction` with bounding box coordinates, the following code snippet shows how to scale the bounding box dimensions: |
Contributor
There was a problem hiding this comment.
Where in the code would this go?
Contributor
Author
There was a problem hiding this comment.
It wouldn't go anywhere since users aren't doing anything with it in the tutorial. I can add to the note saying that this optional when post-processing (if they choose to do so). Or we can expand the tutorial to include drawing the bounding boxes.
BillWagner
approved these changes
Jul 2, 2021
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This LGTM @luisquintanilla
You can 
when ready.
luisquintanilla
added a commit
that referenced
this pull request
Jul 7, 2021
Updating date to reflect changes from #24884
luisquintanilla
added a commit
that referenced
this pull request
Jul 8, 2021
Updating date to reflect changes from #24884
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add note on how to scale bounding box coordinates given by prediction
Fixes #23774
Preview Link