Skip to content

Update Model Builder Doc#24909

Merged
luisquintanilla merged 10 commits intodotnet:mainfrom
jwood803:model-builder-updates
Jul 13, 2021
Merged

Update Model Builder Doc#24909
luisquintanilla merged 10 commits intodotnet:mainfrom
jwood803:model-builder-updates

Conversation

@jwood803
Copy link
Copy Markdown
Contributor

@jwood803 jwood803 commented Jun 30, 2021

Update Model Builder doc to be more up-to-date.

Fixes #24825

Preview

AB#1864083

@dotnet-bot dotnet-bot added this to the July 2021 milestone Jun 30, 2021
@jwood803 jwood803 marked this pull request as ready for review July 2, 2021 20:09
@jwood803 jwood803 requested a review from luisquintanilla as a code owner July 2, 2021 20:09
@jwood803
Copy link
Copy Markdown
Contributor Author

jwood803 commented Jul 2, 2021

@luisquintanilla I believe this is ready for review.

Copy link
Copy Markdown
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jwood803 looks great. I added a few comments

Copy link
Copy Markdown
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

jwood803 and others added 5 commits July 11, 2021 05:28
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
@luisquintanilla
Copy link
Copy Markdown
Contributor

Closing and reopening to trigger build

Copy link
Copy Markdown
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jwood803 and others added 2 commits July 12, 2021 08:49
Co-authored-by: Luis Quintanilla <46974588+luisquintanilla@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@luisquintanilla luisquintanilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@luisquintanilla luisquintanilla merged commit 5fbe7f6 into dotnet:main Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update What is Model Builder and how does it work?

4 participants