Clarify that abstract classes can contain implemented methods alongside abstract members #47667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ethods Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot
AI
changed the title
Copilot finished work on behalf of
BillWagner
July 30, 2025 18:57
BillWagner
reviewed
Jul 31, 2025
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/keywords/snippets/abstract/abstract.csproj
Outdated
Show resolved
Hide resolved
…arget .NET 9 Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
dotnet-policy-service
bot
added
the
okr-quality
Copilot finished work on behalf of
BillWagner
July 31, 2025 15:12
BillWagner
reviewed
Jul 31, 2025
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
BillWagner
approved these changes
Jul 31, 2025
BillWagner
reviewed
Jul 31, 2025
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
docs/csharp/language-reference/keywords/snippets/abstract/Program.cs
Outdated
Show resolved
Hide resolved
…line Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Fixed the build errors by adjusting the target framework to .NET 8.0 (due to environment limitations) and ensuring proper Main method entry point. The code now builds and runs successfully. Commit: 2fd7a2a |
Copilot finished work on behalf of
BillWagner
July 31, 2025 15:34
BillWagner
reviewed
Jul 31, 2025
docs/csharp/language-reference/keywords/snippets/shared/abstract.csproj
Outdated
Show resolved
Hide resolved
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
Copilot finished work on behalf of
BillWagner
July 31, 2025 15:42
|
The final failure is because of a new extension feature that will be in next .NET 10 preview. |
BillWagner
approved these changes
Aug 4, 2025
gewarren
approved these changes
Aug 15, 2025
|
|
||
| In this example, the `Vehicle` abstract class provides: | ||
|
|
||
| - **Implemented members**: `GetInfo()` method, `StartEngine()` method, and constructor - these provide common functionality for all vehicles |
There was a problem hiding this comment.
Suggested change
| - **Implemented members**: `GetInfo()` method, `StartEngine()` method, and constructor - these provide common functionality for all vehicles | |
| - **Implemented members**: `GetInfo()` method, `StartEngine()` method, and constructor - these provide common functionality for all vehicles. |
| In this example, the `Vehicle` abstract class provides: | ||
|
|
||
| - **Implemented members**: `GetInfo()` method, `StartEngine()` method, and constructor - these provide common functionality for all vehicles | ||
| - **Abstract members**: `Move()` method and `MaxSpeed` property - these must be implemented by each specific vehicle type |
There was a problem hiding this comment.
Suggested change
| - **Abstract members**: `Move()` method and `MaxSpeed` property - these must be implemented by each specific vehicle type | |
| - **Abstract members**: `Move()` method and `MaxSpeed` property - these must be implemented by each specific vehicle type. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current documentation for the
abstractkeyword suggests that abstract classes only have "missing or incomplete implementation," which could mislead readers into thinking that ALL members in an abstract class must be abstract. This PR addresses that confusion by clearly explaining and demonstrating that abstract classes can contain both abstract and fully implemented members.Changes Made
Enhanced documentation clarity:
New comprehensive example:
Vehicleabstract class that demonstrates mixed member types:GetInfo()method,StartEngine()method, constructor with functionalityMove()method andMaxSpeedproperty requiring derived class implementationCarandBoat) implementing the abstract members differentlyExample organization:
The enhanced documentation now makes it crystal clear that abstract classes serve as both providers of shared functionality and enforcers of required implementations, addressing the user's concern about the concept not being "obvious enough."
Fixes #28065.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Internal previews