-
Notifications
You must be signed in to change notification settings - Fork 6k
Update .NET 10 documentation with comprehensive feature integration and address review feedback #47938
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start. I have quite a bit of feedback to address.
@copilot Please address all command from @BillWagner and @gewarren |
@copilot please address all review comments. |
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
I've addressed all the comments from both @BillWagner and @gewarren. The documentation has been restructured to remove preview-specific references, integrate features into appropriate sections, fix writing style issues, and move long code examples to separate files. All the requested changes have been implemented. Commit: 16b5fb6
I've addressed all the review comments. The key changes include:
All feedback has been implemented. Commit: 16b5fb6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still more to do.
docs/core/whats-new/dotnet-10/snippets/csharp/WebSocketStreamText.cs
Outdated
Show resolved
Hide resolved
docs/core/whats-new/dotnet-10/snippets/csharp/WebSocketStreamText.cs
Outdated
Show resolved
Hide resolved
docs/core/whats-new/dotnet-10/snippets/csharp/WebSocketStreamText.cs
Outdated
Show resolved
Hide resolved
docs/core/whats-new/dotnet-10/snippets/csharp/WebSocketStreamWrite.cs
Outdated
Show resolved
Hide resolved
docs/core/whats-new/dotnet-10/snippets/csharp/WebSocketStreamWrite.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
@copilot Fix all build warnings, and add a project file in the snippets folder for the code snippets to build correctly. |
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
I've addressed the remaining issues:
The snippets now have a proper MSBuild context for validation while maintaining their role as documentation examples. Commit: 2b7c628 |
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
This is now much better. Do you want to have a look again? |
Co-authored-by: Genevieve Warren <24882762+gewarren@users.noreply.github.com>
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
@copilot Please address remaining comments. |
…ML-DSA types, move WebSocketStream description, fix TLS typo, and remove extra blank lines Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
PoliCheck Scan ReportThe following report lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a PR comment and include this text: #policheck-false-positive. This feedback helps reduce false positives in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
…line before CLI introspection Co-authored-by: BillWagner <493969+BillWagner@users.noreply.github.com>
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
PoliCheck Scan ReportThe following reports lists PoliCheck issues in PR files. Before you merge the PR, you must fix all severity-1 issues. Other issues are also a high priority. The AI Review Details column lists suggestions for either removing or replacing the terms. If you find a false positive result, mention it in a comment that you post to the PR. The feedback helps reduce false positive instances in future scans. ✅ No issues foundMore information about PoliCheckInformation: PoliCheck | Severity Guidance | Term |
Updates the .NET 10 "What's new" documentation to provide a comprehensive overview of all features across previews, with content properly organized by functional areas rather than preview releases. Addresses all review feedback regarding documentation standards, code organization, and build infrastructure.
Key Changes Made
Content Restructuring:
Code Organization & Build Infrastructure:
snippets/csharp/
directorysnippets.csproj
project file to enable build validation of code examplesDocumentation Standards Compliance:
Technical Content Coverage:
any
RuntimeIdentifier support for maximum platform compatibilityThe documentation now provides a cohesive view of .NET 10 capabilities organized by functional domain rather than development timeline, making it more useful for developers planning adoption and implementation.
Fixes #47937.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.
Internal previews