Update public2.cs - Fix typo in CLS-compliance example C# #49925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixing typo mentioned in [This Issue](dotnet#49691) where example for CLS compliance might be confusing. - As checked this is fine for the VB example the C# example needs update
axlee484
requested review from
a team,
BillWagner and
IEvangelist
as code owners
dotnet-policy-service
bot
added
the
community-contribution
BillWagner
requested changes
Nov 17, 2025
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
Hi @axlee484
This needs another change for it to compile correctly. (It's also an old sample that's outside of our build system) The suggested change is needed. If adding a project file is easy, that would be great as well.
| public class Person | ||
| { | ||
| private Int16 personAge = 0; | ||
| private UInt16 personAge = 0; |
Member
There was a problem hiding this comment.
On line 11, a cast is needed (no suggestion, because that line wasn't changed). While here, let's simplify this as well:
public Int16 Age => (Int16)personAge;Also, the snippets build is failing because there isn't a project file in this folder. If it's easy, can you add a project file in this folder? (This looks like old samples that were imported from a different system, so that may require a lot more work than this PR should add)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixing typo mentioned in (Typo in field's CLS compliance example #49691) where example for CLS compliance might be confusing.
As checked this is fine for the VB example the C# example needs update
Fixes #49691