Skip to content

Conversation

@nohwnd
Copy link
Member

@nohwnd nohwnd commented Nov 18, 2025

Summary

TRX plugin is open sourced in github.com/microsoft/testfx repo. The notice is no longer relevant.


Internal previews

📄 File 🔗 Preview link
docs/core/testing/microsoft-testing-platform-extensions-test-reports.md docs/core/testing/microsoft-testing-platform-extensions-test-reports

@nohwnd nohwnd requested a review from IEvangelist as a code owner November 18, 2025 11:40
Copilot AI review requested due to automatic review settings November 18, 2025 11:40
@nohwnd nohwnd requested a review from a team as a code owner November 18, 2025 11:40
@dotnetrepoman dotnetrepoman bot added this to the November 2025 milestone Nov 18, 2025
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Nov 18, 2025
Copilot finished reviewing on behalf of nohwnd November 18, 2025 11:42
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes an outdated licensing notice from the TRX test reports documentation. The notice indicated the package was closed-source, but the TRX plugin has since been open sourced in the microsoft/testfx repository, making the notice obsolete.

  • Removed the IMPORTANT block stating the package uses a "closed-source free to use licensing model"

@BillWagner
Copy link
Member

Hi @nohwnd

Should we provide a link to github.com/microsoft/testfx in this article?

@nohwnd
Copy link
Member Author

nohwnd commented Nov 19, 2025

I think it is okay to not do that. We called out the license when it was not what people would normally expect. Now it is just normal open-source, and we link to the repo directly on the nuget package (and in other places).

Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, and I'll :shipit: now.

@BillWagner BillWagner merged commit 0e45bf5 into dotnet:main Nov 20, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants