Skip to content

Conversation

@DaneRushtonVista
Copy link

Have observed in my test cluster (where we shutdown workloads overnight), that if the Operator shuts down first, the Terminating pods with the finalizer are left hanging even once the Operator restarts the following morning.
This is because the first time the Operator sees a Pod, it treats it as an Add, and doesn't check if it was already in the Terminating state.
Have copied what was being done on the Modified event type so that the Finalizers get run.

This is because when the Operator starts, all objects are Adds, including those already in the Terminating state.
Copy link
Collaborator

@buehler buehler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be properly externalized into a method instead of copy paste?

@buehler
Copy link
Collaborator

buehler commented Oct 28, 2025

Thanks for the collaboration @DaneRushtonVista, when you say "copied over", can it be properly engineered to reduce clutter and maintain a high code quality?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants