[WIP] Use shared SimctlOutputParser from Xamarin.MacDev for simctl JSON parsing by rmarinho · Pull Request #24812 · dotnet/macios

rmarinho · 2026-03-03T17:38:35Z

Summary

This PR refactors GetAvailableDevices.RunSimCtlAsync to use the shared SimctlOutputParser from the Xamarin.MacDev submodule (dotnet/macios-devtools) instead of inline JSON parsing.

Plan

We're building shared Apple CLI library APIs in dotnet/macios-devtools to support the maui CLI commands (spec: dotnet/maui#34217). Since macios already uses macios-devtools as a submodule at external/Xamarin.MacDev, we can share the parsing logic between the MSBuild tasks and the CLI tool.

What this PR does

Updates the submodule to include the new SimctlOutputParser and model classes
Replaces inline simctl JSON parsing in RunSimCtlAsync with:
- SimctlOutputParser.ParseDevices(json) — returns typed SimulatorDeviceInfo objects with UDID, Name, State, IsAvailable, AvailabilityError, Platform, OSVersion
- SimctlOutputParser.ParseRuntimes(json) — returns typed SimulatorRuntimeInfo objects with SupportedArchitectures
Preserves all business logic — MSBuild metadata, devicetypes lookup, RuntimeIdentifier computation, platform filtering, CanRunArm64

Benefits

Tested: The shared parser has 65+ unit tests in macios-devtools
Single source of truth: Changes to simctl JSON format only need fixing in one place
Shared across tools: Same parser used by both MSBuild tasks and the upcoming maui CLI

Dependencies

Depends on dotnet/macios-devtools#158 merging first — the submodule currently points to the feature branch
Once Bump ModernHttpClient to set AllowAutoRedirect to true when building inside Xamarin's SDK #158 merges, we'll update the submodule pointer to main

Future work

Move devicetypes parsing into the shared parser (productFamily, minRuntime, maxRuntime)
Add devicectl physical device parsing to the shared parser
Add a ParseDeviceTypes method to SimctlOutputParser

cc @rolfbjarne

rmarinho · 2026-03-03T17:46:28Z

Updated to use ALL shared parsers — now zero inline JSON parsing remains:

SimctlOutputParser.ParseDevices + ParseRuntimes + ParseDeviceTypes
DeviceCtlOutputParser.ParseDevices (new)

System.Text.Json and Xamarin.Utils imports removed from GetAvailableDevices.cs.
Net result: -45 lines, 75+ unit tests backing the parsers.

Depends on dotnet/macios-devtools#158 (which now includes ParseDeviceTypes and DeviceCtlOutputParser).

vs-mobiletools-engineering-service2 · 2026-03-09T13:04:10Z

✅ [CI Build #324c76e] Build passed (Build packages) ✅

Pipeline on Agent
Hash: 324c76e4093b997aae1d89051220962ba2adcbad [PR build]

vs-mobiletools-engineering-service2 · 2026-03-09T13:08:58Z

✅ [CI Build #324c76e] Build passed (Detect API changes) ✅

Pipeline on Agent
Hash: 324c76e4093b997aae1d89051220962ba2adcbad [PR build]

vs-mobiletools-engineering-service2 · 2026-03-09T13:23:34Z

🔥 [CI Build #324c76e] Build failed (Build macOS tests) 🔥

Build failed for the job 'Build macOS tests' (with job status 'Failed')

Pipeline on Agent
Hash: 324c76e4093b997aae1d89051220962ba2adcbad [PR build]

vs-mobiletools-engineering-service2 · 2026-03-09T13:30:47Z

✅ API diff for current PR / commit

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

✅ API diff vs stable

NET (empty diffs)

iOS: vsdrops gist ( No breaking changes )
tvOS: vsdrops gist ( No breaking changes )
MacCatalyst: vsdrops gist ( No breaking changes )
macOS: vsdrops gist ( No breaking changes )

ℹ️ Generator diff

Generator Diff: vsdrops (html) vsdrops (raw diff) gist (raw diff) - Please review changes)

Pipeline on Agent
Hash: 324c76e4093b997aae1d89051220962ba2adcbad [PR build]

Refactor GetAvailableDevices.RunSimCtlAsync to use the shared SimctlOutputParser from the Xamarin.MacDev submodule instead of inline JSON parsing. This: - Reuses tested parsing logic (65+ unit tests in macios-devtools) - Shares the parser across both MSBuild tasks and the MAUI CLI tool - Keeps devicetypes parsing inline (not yet in shared parser) - Preserves all MSBuild metadata, filtering, and discarding logic Depends on dotnet/macios-devtools PR #158 being merged to main. The submodule currently points to feature/simulator-management. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Refactor GetAvailableDevices to use all three shared parsers: - SimctlOutputParser.ParseDevices: simulator device extraction - SimctlOutputParser.ParseRuntimes: runtime extraction - SimctlOutputParser.ParseDeviceTypes: devicetypes extraction - DeviceCtlOutputParser.ParseDevices: physical device extraction This eliminates all inline JSON parsing (System.Text.Json and Xamarin.Utils JsonExtensions no longer needed in this file). The only remaining code is MSBuild-specific TaskItem mapping, platform filtering, RuntimeIdentifier computation, and CanRunArm64. Net result: -45 lines, zero inline JSON parsing. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Fix NU1605 package downgrade error: Xamarin.MacDev references System.Text.Json 9.0.4, while Xamarin.MacDev.Tasks pinned 8.0.5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

- XamarinTask: match ICustomLogger nullable signatures (Exception?, object?[]) - GetAvailableDevices: add using Xamarin.Utils for ApplePlatform - Update submodule to latest (6a2d99b) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

AppleSdkSettings was marked [Obsolete] in macios-devtools PR #140 (XcodeLocator). Existing usages in Sdks.cs, CompileAppManifest.cs, and DetectSdkLocation.cs are intentional pending full migration. TreatWarningsAsErrors=true promotes the warning to an error. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Point submodule from feature/simulator-management branch to main, which now includes the merged simulator management APIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

rmarinho · 2026-03-09T15:54:05Z

Superseded by #24856 — recreated under dev/ branch prefix so CI triggers.

rmarinho mentioned this pull request Mar 3, 2026

Add simulator management APIs dotnet/macios-devtools#158

Merged

This comment has been minimized.

Sign in to view

rmarinho force-pushed the feature/use-macios-devtools-simctl-parser branch from d76976e to b31f386 Compare March 4, 2026 16:12

rmarinho marked this pull request as ready for review March 4, 2026 16:12

rmarinho requested review from emaf, mauroa and rolfbjarne as code owners March 4, 2026 16:12

This comment has been minimized.

Sign in to view

rmarinho force-pushed the feature/use-macios-devtools-simctl-parser branch from b31f386 to 324c76e Compare March 9, 2026 12:40

rmarinho and others added 6 commits March 9, 2026 15:52

Bump System.Text.Json to 9.0.4 to match Xamarin.MacDev submodule

19339b1

Fix NU1605 package downgrade error: Xamarin.MacDev references System.Text.Json 9.0.4, while Xamarin.MacDev.Tasks pinned 8.0.5. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Update macios-devtools submodule to main (PR #158 merged)

492716e

Point submodule from feature/simulator-management branch to main, which now includes the merged simulator management APIs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

rmarinho force-pushed the feature/use-macios-devtools-simctl-parser branch from 324c76e to 492716e Compare March 9, 2026 15:53

rmarinho mentioned this pull request Mar 9, 2026

Use shared SimctlOutputParser from Xamarin.MacDev for simctl JSON parsing #24856

Open

rmarinho closed this Mar 9, 2026

Conversation

rmarinho commented Mar 3, 2026

Summary

Plan

What this PR does

Benefits

Dependencies

Future work

Uh oh!

rmarinho commented Mar 3, 2026

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

vs-mobiletools-engineering-service2 commented Mar 9, 2026

✅ [CI Build #324c76e] Build passed (Build packages) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2026

✅ [CI Build #324c76e] Build passed (Detect API changes) ✅

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2026

🔥 [CI Build #324c76e] Build failed (Build macOS tests) 🔥

Uh oh!

vs-mobiletools-engineering-service2 commented Mar 9, 2026

✅ API diff for current PR / commit

✅ API diff vs stable

ℹ️ Generator diff

Uh oh!

rmarinho commented Mar 9, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants