-
Notifications
You must be signed in to change notification settings - Fork 402
Switch to dotnet-watch delta appliers #9758
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drewnoakes
reviewed
Sep 8, 2025
...rosoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/ProjectHotReloadSession.cs
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Sep 8, 2025
ad8a1af
to
9f0b5ec
Compare
drewnoakes
reviewed
Sep 16, 2025
...udio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/VisualStudioBrowserRefreshServer.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/DeltaApplier.cs
Outdated
Show resolved
Hide resolved
...rosoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/ProjectHotReloadSession.cs
Show resolved
Hide resolved
...rosoft.VisualStudio.ProjectSystem.Managed/ProjectSystem/HotReload/ProjectHotReloadSession.cs
Show resolved
Hide resolved
...ft.VisualStudio.ProjectSystem.Managed/ProjectSystem/Utilities/ConfiguredProjectExtensions.cs
Show resolved
Hide resolved
LGTM though will defer to @LittleLittleCloud for final sign off. |
...udio.ProjectSystem.Managed.VS/ProjectSystem/VS/HotReload/VisualStudioBrowserRefreshServer.cs
Show resolved
Hide resolved
LittleLittleCloud
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Microsoft Reviewers: Open in CodeFlow
Replaces the use of default DeltaApplier implemented in WebTools with one from dotnet-watch (
DefaultHotReloadClient
type shared viaMicrosoft.DotNet.HotReload.Client
source package).The Hot Reload client is wrapped in
DeltaApplier
type that implements the existingIDeltaApplier
interface.Adds a new interface
IProjectHotReloadSessionWebAssemblyCallback
for Web Project to implement. Once implemented the Hot Reload session implementation will switch to using dotnet-watchWebAssemblyHotReloadClient
as the underlying implementation of theDeltaApplier
for WASM app.Adds
AbstractBrowserRefreshServerAccessor
that exposes Browser Refresh server implementation fromMicrosoft.DotNet.HotReload.Client
source package to WebTools, so that we can replace the implementation in WebTools.Adds Browser Refresh middleware (package
Microsoft.DotNet.HotReload.Web.Middleware
published by dotnet/sdk) to Managed Project System VSIX to distribute with VS. Once we switch WebTools toAbstractBrowserRefreshServerAccessor
it will stop using the middleware from the SDK and switch to the middleware included in Project System VSIX. This will allow us to version the client (IDE) and the middleware together instead of having to support all combinations of VS and SDK versions.Contributes to
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2398434
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2398433
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2398432