Allow the LSP workspace configuration handler to get the open solution from the project system. #79145
+10
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n from the project system.
| @@ -48,7 +51,7 @@ private ProjectDebugConfiguration GetProjectDebugConfiguration(Project project) | |||
| { | |||
| var isExe = project.CompilationOptions?.OutputKind is OutputKind.ConsoleApplication or OutputKind.WindowsApplication; | |||
| var targetsDotnetCore = _targetFrameworkManager.IsDotnetCoreProject(project.Id); | |||
| return new ProjectDebugConfiguration(project.FilePath!, project.OutputFilePath!, GetProjectName(project), targetsDotnetCore, isExe, project.Solution.FilePath); | |||
| return new ProjectDebugConfiguration(project.FilePath!, project.OutputFilePath!, GetProjectName(project), targetsDotnetCore, isExe, _projectSystem.SolutionPath); | |||
There was a problem hiding this comment.
Should we just have it update the Solution FilePath instead? Otherwise this feels like we are setting ourselves up for bugs later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the C# extension allows the user to open a solution file then another and because we have not implemented unload solution, the solution attributes never change and the project debug configuration always reports the first solution opened. This manifests itself when the user generates build assets for their workspace. The generated tasks.json will have build tasks for the first opened solution.
Resolves dotnet/vscode-csharp#8377