Simplify collections, and produce less pooling work #79153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Jun 26, 2025
src/Dependencies/Collections/Extensions/IEnumerableExtensions.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jun 26, 2025
src/Dependencies/Collections/Extensions/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jun 26, 2025
src/Dependencies/Collections/Extensions/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
commented
Jun 26, 2025
src/Dependencies/Collections/Extensions/ImmutableArrayExtensions.cs
Outdated
Show resolved
Hide resolved
jasonmalinowski
approved these changes
Jun 27, 2025
| @@ -69,7 +69,7 @@ public static ImmutableArray<T> ToImmutableArrayOrEmpty<T>(this IEnumerable<T>? | |||
| { | |||
| if (items == null) | |||
| { | |||
| return ImmutableArray.Create<T>(); | |||
| return []; | |||
There was a problem hiding this comment.
Although I don't normally mind the change, if this is a source package does this create a problem for any of our consumers that aren't on a new enough compiler?
There was a problem hiding this comment.
Collection expressions were C# 12. we're already about to ship 14. I would expect at most we would want people on N-1. Not arbitrarily far back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.