Fix Chinese translation of dotnet workload search command #50265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: marcpopMSFT <12663534+marcpopMSFT@users.noreply.github.com>
Copilot
AI
changed the title
dotnet workload repair
Copilot finished work on behalf of
marcpopMSFT
August 14, 2025 21:05
marcpopMSFT
approved these changes
Aug 14, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a localization issue where the dotnet workload search command was being incorrectly translated to Chinese characters in localized environments, making it an invalid command that users couldn't execute.
- Added a
{Locked="dotnet workload search"}comment to the source.resxfile to prevent translation of the CLI command - Updated all
.xlflocalization files to mark translations as needing review and include the locking directive - Corrected Chinese translations to preserve the English command while keeping the rest of the message localized
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| CliCommandStrings.resx | Added locking comment to prevent translation of "dotnet workload search" command |
| CliCommandStrings.zh-Hans.xlf | Fixed Chinese (Simplified) translation to preserve English command |
| CliCommandStrings.zh-Hant.xlf | Fixed Chinese (Traditional) translation to preserve English command |
| CliCommandStrings.cs.xlf | Updated Czech translation state and added locking note |
| CliCommandStrings.de.xlf | Updated German translation state and added locking note |
| CliCommandStrings.es.xlf | Updated Spanish translation state and added locking note |
| CliCommandStrings.fr.xlf | Updated French translation state and added locking note |
| CliCommandStrings.it.xlf | Updated Italian translation state and added locking note |
| CliCommandStrings.ja.xlf | Updated Japanese translation state and added locking note |
| CliCommandStrings.ko.xlf | Updated Korean translation state and added locking note |
| CliCommandStrings.pl.xlf | Updated Polish translation state and added locking note |
| CliCommandStrings.pt-BR.xlf | Updated Portuguese (Brazil) translation state and added locking note |
| CliCommandStrings.ru.xlf | Updated Russian translation state and added locking note |
| CliCommandStrings.tr.xlf | Updated Turkish translation state and added locking note |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Chinese localization was incorrectly translating the
dotnet workload searchcommand to Chinese characters (dotnet 工作负载搜索) instead of preserving the literal English command. This caused confusion for Chinese users who would see an invalid command suggestion.Problem:
When running
dotnet workload repairin a Chinese environment with no workloads installed, users would see:The command
dotnet 工作负载搜索is not valid - CLI commands should remain in English even in localized environments.Solution:
{Locked="dotnet workload search"}comment to theNoWorkloadsToRepairstring inCliCommandStrings.resxto prevent the command from being translated.xlflocalization files with the proper locking directiveAfter fix:
Chinese users now see the correct output:
The command is now properly shown as
"dotnet workload search"in English, consistent with other similar command suggestions throughout the CLI.Testing:
zh-Hans) environmentThis follows the established pattern used by other CLI command strings in the codebase that use the
{Locked=}directive to prevent translation of command names.Fixes #50235.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.