Avoid copying http-client.env.json to the output folder #50280
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Area-AspNetCore
|
Thanks for your PR, @@Varorbc. |
drewnoakes
reviewed
Aug 18, 2025
src/StaticWebAssetsSdk/Sdk/Sdk.StaticWebAssets.StaticAssets.ProjectSystem.props
Outdated
Show resolved
Hide resolved
drewnoakes
reviewed
Aug 18, 2025
| @@ -40,6 +40,9 @@ Copyright (c) .NET Foundation. All rights reserved. | |||
| <Content Include="**\*.config" ExcludeFromSingleFile="true" CopyToPublishDirectory="PreserveNewest" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder);$(DefaultWebContentItemExcludes)" Condition="'$(ExcludeConfigFilesFromBuildOutput)'=='true'" /> | |||
| <Content Include="**\*.json" ExcludeFromSingleFile="true" CopyToPublishDirectory="PreserveNewest" Exclude="$(DefaultItemExcludes);$(DefaultExcludesInProjectFolder);$(DefaultWebContentItemExcludes)" Condition="'$(ExcludeConfigFilesFromBuildOutput)'=='true'" /> | |||
|
|
|||
| <!-- Avoid copying http-client.env.json to the output directory. --> | |||
| <Content Update="**\http-client.env.json" CopyToOutputDirectory="Never" CopyToPublishDirectory="Never" /> | |||
There was a problem hiding this comment.
Do these files actually need to be Content items? Could they be added to DefaultItemExcludes above, on line 25.
There was a problem hiding this comment.
Previously, I added it to DefaultItemExcludes, which resulted in the file not being visible in Vs.
There was a problem hiding this comment.
Maybe it can/should be a None item instead.
There was a problem hiding this comment.
Just throwing ideas around. Someone from the SDK team will know better.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/aspnetcore#63263