CLI --self-contained description is wrong #51088
Open
+27
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@adegeo you'll need to update the xlf files on your fork to bump the translations. After that, you'll probably need to update the CLI snapshot tests. |
3 tasks
nagilson
approved these changes
Oct 1, 2025
There was a problem hiding this comment.
That's a great call out. By default, I didn't mean the value of the command argument but the value of the SelfContained property itself. SelfContained itself is 'false' by default (with no argument) but providing --self-contained makes it true. I don't think we need this breaking change string at this point.
|
@baronfel I removed the lines from the translation files. I don't know what to do about the other item you said. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like #32656 updated the
--self-containeddescription incorrectly. The code change that triggered the old PR was actually related to the --runtime parameter no longer enforcing self-contained=true. It had nothing to do with the --self-contained option itself.--self-contained is an option argument type and defaults to true when passed.
@baronfel