Skip to content

Conversation

dsplaisted
Copy link
Member

@dsplaisted dsplaisted commented Oct 3, 2025

See #51067. The .ps1 script prevents the CLI from correctly processing --. So we'll remove the script, This will regress to the "terminate batch job" behavior described in #49623, but that's better than incorrectly processing command line arguments.

Description

Removes dnx.ps1 helper script.

Customer impact

Fixes processing of -- when calling dnx from PowerShell.
Brings back "Terminate Batch Job" prompt when CTRL+C is pressed, but this is preferrable to incorrectly processing the command line.

Regression

dnx is new in .NET 10. This was a regression from a previous preview release.

Risk

Low

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

/ba-g GenerateBundle known issue

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

This LGTM but we need to get Tactics approval

@baronfel
Copy link
Member

baronfel commented Oct 3, 2025

@dotnet/dotnet-docker-admin this PR would remove the dnx.ps1 file due to negative user impacts - it looks like this file is part of the Windows containers - how much work is it to clean it up there?

@lbussell
Copy link
Contributor

lbussell commented Oct 3, 2025

@dotnet/dotnet-docker-admin this PR would remove the dnx.ps1 file due to negative user impacts - it looks like this file is part of the Windows containers - how much work is it to clean it up there?

It's easy to remove it. dotnet-docker's PR validation should fail whenever the change flows in, at which point we can just revert the change.

@rbhanda rbhanda added Servicing-approved breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug and removed Servicing-consider labels Oct 7, 2025
@rbhanda rbhanda added this to the 10.0.0 milestone Oct 7, 2025
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET SDK Breaking Change Notification email list.

You can refer to the .NET SDK breaking change guidelines

@marcpopMSFT marcpopMSFT merged commit c637238 into dotnet:release/10.0.1xx Oct 7, 2025
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change Using this label will notify dotnet/compat and trigger a request to file a compat bug needs-breaking-change-doc-created Servicing-approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants