This repository was archived by the owner on Nov 20, 2023. It is now read-only.
Support replacement tokens in environment variables #377#1611
Open
Phiph wants to merge 5 commits intodotnet:mainfrom
Open
Support replacement tokens in environment variables #377#1611Phiph wants to merge 5 commits intodotnet:mainfrom
Phiph wants to merge 5 commits intodotnet:mainfrom
Conversation
Author
|
@microsoft-github-policy-service agree |
Author
|
@dotnet-policy-service agree |
Phiph
commented
Sep 28, 2023
| }; | ||
| } | ||
| } | ||
|
|
Author
There was a problem hiding this comment.
This file isn't DRY or sexy... it's a bit of a copy and paste - but any suggestions I'm all ears!
Author
|
@philliphoff & @davidfowl any chance this could get a review please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #377
See issue for update and analysis, I would welcome feedback on the code - I do feel it's a bit hacky to be honest!