Enhance dotnet.generateAssets command to accept skipPrompt parameter for asset generation #8510
Conversation
…for asset generation
Co-authored-by: Andrew Wang <waan@microsoft.com>
Co-authored-by: Andrew Wang <waan@microsoft.com>
|
@WardenGnaw put everything you suggested! Let me know if it's ok now |
There was a problem hiding this comment.
LGTM provided @WardenGnaw is good with these updates. So please wait for his approval.
Also tagging @dibarbet and @JoeRobich to see if they have any concerns.
Co-authored-by: Andrew Wang <waan@microsoft.com>
| @@ -53,8 +53,8 @@ export function registerDebugger( | |||
| ); | |||
|
|
|||
| context.subscriptions.push( | |||
| vscode.commands.registerCommand('dotnet.generateAssets', async (selectedIndex) => { | |||
| if (!(await promptForDevKitDebugConfigurations())) { | |||
| vscode.commands.registerCommand('dotnet.generateAssets', async (selectedIndex: number, options: { skipPrompt?: boolean } = {}) => { | |||
There was a problem hiding this comment.
I assume the expectation is that the container tools extension is calling this programatically and can pass in the value they want here?
Additionally, generate assets can be called from the command palette directly, but generally command palette options don't pass in arguments. Can you verify the generate assets command still works there?
There was a problem hiding this comment.
Yep. The arguments shouldnt matter via command since its only used for calling it via the command API.
We already do this today with selectedIndex, now we are just creating another parameter for options
There was a problem hiding this comment.
Yep. The arguments shouldnt matter via command since its only used for calling it via the command API.
However the command is exposed today as a user-invokable command. Should we remove that?
There was a problem hiding this comment.
Its intended to be invokable, and if users have DevKit installed, they should see the prompt.
|
@claudiaregio You will need to run the linter with |
Bug: #8414