Open
Conversation
This may mess up our output parsing. Please see dotnet#2269, One concern is whether TERM=dumb would cause other failures, but in general this is only meant to disable ansi scape codes (for color and formatting) which we dont want, and this is recommended to be set for scripting. https://linux.die.net/man/7/term
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds environment variable configurations to normalize command execution output by suppressing color codes and standardizing terminal behavior. The changes ensure consistent output parsing across different user environments.
- Adds
NO_COLOR,TERM, andGREP_OPTIONSenvironment variables to command execution options - Updates the environment variable logging list to include the new variables for debugging purposes
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| vscode-dotnet-runtime-library/src/Utils/CommandExecutor.ts | Sets NO_COLOR='1', TERM='dumb', and GREP_OPTIONS=undefined for command execution to ensure clean, parseable output |
| vscode-dotnet-runtime-library/src/Utils/TypescriptUtilities.ts | Adds GREP_OPTIONS and NO_COLOR to the list of environment variables logged for debugging |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #2269
The old env variables may mess up our output parsing, so we should unset them or prevent color formatting in output. Please see #2269
One concern is whether TERM=dumb would cause other failures, but in general this is only meant to disable ansi scape codes (for color and formatting) which we dont want, and this is recommended to be set for scripting. https://linux.die.net/man/7/term