Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 3, 2025

Backport of #13818 to release/10.0

/cc @Epica3055

Proposed changes

Add code to see if BackColor or ForeColor is specified in dark mode, if so then use the specified color, if not then let the renderer decide the color.

Screenshots

Before

image

After

image

@github-actions github-actions bot requested a review from a team as a code owner September 3, 2025 06:39
Copy link

codecov bot commented Sep 3, 2025

Codecov Report

❌ Patch coverage is 4.76190% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.08604%. Comparing base (93a2ef9) to head (2355f3b).
⚠️ Report is 14 commits behind head on release/10.0.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           release/10.0      #13839         +/-   ##
======================================================
- Coverage      77.10744%   77.08604%   -0.02140%     
======================================================
  Files              3273        3272          -1     
  Lines            644882      644594        -288     
  Branches          47686       47679          -7     
======================================================
- Hits             497252      496892        -360     
- Misses           143951      144025         +74     
+ Partials           3679        3677          -2     
Flag Coverage Δ
Debug 77.08604% <4.76190%> (-0.02140%) ⬇️
integration 19.02211% <0.00000%> (+0.03275%) ⬆️
production 51.89553% <4.76190%> (-0.02849%) ⬇️
test 97.41319% <ø> (+0.00070%) ⬆️
unit 49.30261% <4.76190%> (-0.03718%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

merriemcgaw
merriemcgaw previously approved these changes Sep 3, 2025
Copy link
Member

@merriemcgaw merriemcgaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to limit code-path changes to dark mode.

@dotnet-policy-service dotnet-policy-service bot added the waiting-author-feedback The team requires more information from the author label Sep 4, 2025
@LeafShi1 LeafShi1 added waiting-review This item is waiting on review by one or more members of team and removed waiting-author-feedback The team requires more information from the author labels Sep 5, 2025
Copy link
Member

@KlausLoeffelmann KlausLoeffelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!

@KlausLoeffelmann KlausLoeffelmann merged commit 2a4c19b into release/10.0 Sep 7, 2025
8 checks passed
@KlausLoeffelmann KlausLoeffelmann deleted the backport/pr-13818-to-release/10.0 branch September 7, 2025 21:41
@dotnet-policy-service dotnet-policy-service bot removed the waiting-review This item is waiting on review by one or more members of team label Sep 7, 2025
@KlausLoeffelmann
Copy link
Member

@Epica3055,let'smake sure, we have this modification also in main, because I missed it there.
@merriemcgaw, @LeafShi1 FYI.

@Epica3055
Copy link
Member

Epica3055 commented Sep 8, 2025

@KlausLoeffelmann
Please see this pr 13834, in which I removed these two properties
internal bool BackColorSet { get; set; }
internal bool ForeColorSet { get; set; }
I think if you think pr 13834 is reasonable, then we don't have to port this modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants