-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[release/10.0] fix #13813 : Dark Mode: The ForeColor & BackColor properties are not working for the controls #13839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/10.0] fix #13813 : Dark Mode: The ForeColor & BackColor properties are not working for the controls #13839
Conversation
…working for the controls
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## release/10.0 #13839 +/- ##
======================================================
- Coverage 77.10744% 77.08604% -0.02140%
======================================================
Files 3273 3272 -1
Lines 644882 644594 -288
Branches 47686 47679 -7
======================================================
- Hits 497252 496892 -360
- Misses 143951 144025 +74
+ Partials 3679 3677 -2
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to limit code-path changes to dark mode.
src/System.Windows.Forms/System/Windows/Forms/Controls/Buttons/ButtonBase.cs
Show resolved
Hide resolved
src/System.Windows.Forms/System/Windows/Forms/Controls/Buttons/ButtonBase.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
@Epica3055,let'smake sure, we have this modification also in main, because I missed it there. |
@KlausLoeffelmann |
Backport of #13818 to release/10.0
/cc @Epica3055
Proposed changes
Add code to see if BackColor or ForeColor is specified in dark mode, if so then use the specified color, if not then let the renderer decide the color.
Screenshots
Before
After