-
Notifications
You must be signed in to change notification settings - Fork 1
docs: Update documentation for Phase 4 Scripting completion #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
doublegate
wants to merge
8
commits into
main
from
claude/create-cc-component-01CukTkVbRvzVFGqX5q1Kman
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
6b59a65
docs: Update documentation for Phase 4 Scripting completion
claude d004001
Update README.md
doublegate b7fb04e
Update scripts/README.md
doublegate 6757445
Update scripts/README.md
doublegate 79991e8
Update README.md
doublegate 0a58f0d
Update scripts/README.md
doublegate faad08f
Fix RUSTSEC-2025-0055: Update tracing-subscriber to 0.3.20 (#31)
Copilot a5e4ee3
fix: Address PR #27 review comments - correct line counts, URL patter…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The API function signatures listed here are inconsistent with the more detailed documentation in
scripts/README.md. This can cause confusion for developers. For example:irc.ctcp(target, command, args)here vs.irc.ctcp(target, command)in the script docs. Theargsparameter seems important.[]to denote optional parameters (e.g.,irc.topic(channel, [topic])), which is clearer and should be adopted here for consistency.irc.modehas different signatures:irc.mode(target, modes)here vs.irc.mode(channel, mode, [params])in the script docs.Please review and align the changelog with the primary
scripts/README.mddocumentation.