fix: add version field to internal workspace packages to enable ORT analyzer#1959
fix: add version field to internal workspace packages to enable ORT analyzer#1959willebra wants to merge 1 commit intodoubleopen-io:mainfrom
Conversation
|
I guess the playwright test fails due to no access to some secrets on my end. |
Actually, I don't believe that adding a (dummy) version will help us getting rid of that issue. Instead, we should wait for an ORT release that includes oss-review-toolkit/ort#11704 and upgrade the ORT Server to it, and rerun the analysis. Also see oss-review-toolkit/ort#9699. |
Interesting, that's somewhat unexpected. Let's be clear on that: There's nothing wrong with omitting the version for unpublished projects. So specifying the version works around a bug in ORT, and ideally it should be fixed in ORT. |
|
I think the stregth in this AI agent fixing approach is twofold: first it finds quick fixes for users who are not analyzer experts and second it generates a knowledge base of the fixes, enabling fixing bugs and other analyzer improvements. |
|
What's the reason for not adding |
Summary
"version": "0.0.0"to the five internal workspace packages that had no version field:common-helpers,database,s3-helpers,spdx-validation,validation-helpersWhy
ORT's NPM analyzer builds package identifiers as
NPM::<name>:<version>. Without aversionfield the identifierbecomes e.g.
NPM::common-helpers:(empty version), which ORT cannot match to any resolved package — causing theanalyzer job to fail entirely with:
0.0.0is the standard convention for private, unpublished monorepo packages. Since none of these are published to a registry, the version value is arbitrary — ORT just needs it to be non-empty.Verification
Fix was validated by re-running ORT analysis against this branch. The analyzer completed successfully with no recurrence of the missing-package-reference error.