Small changes to environment variable handling in workflows#1962
Merged
sschuberth merged 3 commits intomainfrom Apr 30, 2026
Merged
Small changes to environment variable handling in workflows#1962sschuberth merged 3 commits intomainfrom
sschuberth merged 3 commits intomainfrom
Conversation
This variable has been completely removed. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.io>
lamppu
temporarily deployed
to
unittest-environment
GitHub Actions
Inactive
lamppu
temporarily deployed
to
unittest-environment
GitHub Actions
Inactive
lamppu
had a problem deploying
to
test-environment
GitHub Actions
Failure
lamppu
force-pushed
the
workflow-variables
branch
from
6d9f109 to
2c827ce
Compare
lamppu
force-pushed
the
workflow-variables
branch
from
8b5d9d5 to
a376fb2
Compare
sschuberth
reviewed
Apr 30, 2026
| environment: test-environment | ||
| env: | ||
| DATABASE_URL: ${{ vars.DATABASE_URL }} | ||
| NEXTAUTH_SECRET: ${{ secrets.NEXTAUTH_SECRET }} |
Member
There was a problem hiding this comment.
In the commit message title, the leading "backtick" around NEXTAUTH_SECRET is actually a "fronttick", it seems 😸
Also remove the now unneeded secret from the Playwright workflow. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.io>
These workflows no longer need restrictions to accessing secrets, and the `DATABASE_URL` environment variable can now be read from repository variables. Signed-off-by: Johanna Lamppu <johanna.lamppu@doubleopen.io>
lamppu
force-pushed
the
workflow-variables
branch
from
a376fb2 to
950bf52
Compare
sschuberth
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Unit-test and Playwright workflows no longer need environments with restrictions to access secrets, so remove those environments from the workflows altogether. One remaining variable is read from repository variables for convenience, as it's referenced in several places. Others are removed/hard-coded.
This should make it so that workflows can access the needed variables even if the PR comes from a fork.