Open
Conversation
Dropped rake task to sh because the tasks are more brittle than the binary interface, and ultimately it just shells out in the end, anyway. Was able to remove a lot of the tedious parts (setting the load paths) because they're now RSpec defaults. Because spec is in the load path, don't need to do the requires relative to the file, can just require spec helper directly. The mocks in the before(:all) were blowing up because RSpec resets mocks after each example is run. So it doesn't let you have mocks that span the duration of the tests (at least that's what I expect the reasoning to be). Since they didn't require any particular behaviour or interface, I just replaced them with empty objects. Took out the check_messages spec method, there's a better version baked into rspec as the =~ operator There is still one test failing: $ rspec spec/rubarb/server_failure_spec.rb --line 66 Tried looking into it, but IDK why (it doesn't seem to raise on the no method error, though when I explicitly raise, it suffers a "Connection Failure" We should probably also get rid of Jeweler, it abstracts things that are easy to do by hand (build and push gems). And since it has the gemspec embedded in it, inside the Rakefile, we can't gell Bundler to use our gemspec, so we have to list all deps in both places. I was going to do this, but couldn't figure out how we track our version, so figured I'd let someone else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dropped rake task to sh because the tasks are more brittle than the
binary interface, and ultimately it just shells out in the end, anyway.
Was able to remove a lot of the tedious parts (setting the load paths)
because they're now RSpec defaults.
Because spec is in the load path, don't need to do the requires
relative to the file, can just require spec helper directly.
The mocks in the before(:all) were blowing up because RSpec resets mocks
after each example is run. So it doesn't let you have mocks that span
the duration of the tests (at least that's what I expect the reasoning
to be). Since they didn't require any particular behaviour or interface,
I just replaced them with empty objects.
Took out the check_messages spec method, there's a better version baked
into rspec as the =~ operator
There is still one test failing:
$ rspec spec/rubarb/server_failure_spec.rb --line 66
Tried looking into it, but IDK why (it doesn't seem to raise on the no
method error, though when I explicitly raise, it suffers a "Connection
Failure"
We should probably also get rid of Jeweler, it abstracts things that are
easy to do by hand (build and push gems). And since it has the gemspec
embedded in it, inside the Rakefile, we can't gell Bundler to use our
gemspec, so we have to list all deps in both places. I was going to do this,
but couldn't figure out how we track our version, so figured I'd let
someone else.