fix: await async authorize* helpers in tests#24
Merged
dougdevitre merged 1 commit intomainfrom Apr 14, 2026
Merged
Conversation
authorizeOutbound was refactored to async (Promise<{result, userId?}>)
and authorizeRecords to async (Promise<null | Response>) when Clerk JWT
support was added, but the unset-key tests still called them synchronously
and compared the returned Promise to null — always failing.
Adds await + matches the new return shapes. 286/286 pass locally.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two unset-key tests compared a Promise to null (always fails). Adds await + matches new return shapes after the Clerk JWT refactor. Restores green main and unblocks the two open dependabot PRs (#22, #23).